Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipam: fix ippool with single dual-stack address #3054

Merged
merged 1 commit into from Jul 19, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 19, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #3050

WHAT

馃 Generated by Copilot at 345c2bf

This pull request enhances the ipPool annotation feature for pods and statefulsets, and increases the timeout-minutes for some GitHub workflow jobs. It fixes a bug in the pod controller's acquireAddress function, adds more test cases for the ipPool annotation in the test/e2e/kube-ovn/ipam/ipam.go file, and adjusts the .github/workflows/build-x86-image.yaml and .github/workflows/scheduled-e2e.yaml files to prevent timeout failures.

馃 Generated by Copilot at 345c2bf

Oh we are the kube-ovn crew and we have a job to do
We build and test the image and we push it to the hub
We tweak the timeouts and the tests to make them run just right
And we fix the ipPool bug and add a new feature tonight

HOW

馃 Generated by Copilot at 345c2bf

  • Increase the timeout-minutes for the GitHub workflow jobs that build the x86 image and run the conformance tests (link, link)
  • Fix a bug that causes pod address allocation to fail when the ipPool annotation has mixed protocols (link)
  • Support the use case where the ipPool annotation specifies a single IP address instead of a range or a list (link)
  • Modify the test case for the ipPool annotation in the test/e2e/kube-ovn/ipam/ipam.go file to cover different numbers of replicas and delete the statefulset after each iteration (link)

@zhangzujian zhangzujian added bug Something isn't working need backport labels Jul 19, 2023
@zhangzujian zhangzujian merged commit 42f35a3 into kubeovn:master Jul 19, 2023
59 checks passed
@zhangzujian zhangzujian deleted the fix-ipam branch July 19, 2023 05:21
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipam: custom vpc: sts ip pool not use the static ipv6 address in ip pool annos
2 participants