Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix multus installation #3062

Merged
merged 1 commit into from
Jul 24, 2023
Merged

ci: fix multus installation #3062

merged 1 commit into from
Jul 24, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 23, 2023

What type of this PR

  • CI

Which issue(s) this PR fixes:

Install the stable version in CI.

k8snetworkplumbingwg/multus-cni#1126

WHAT

馃 Generated by Copilot at 81499b3

This pull request enhances the Makefile, the e2e test file, and the workflow file for the iptables-vpc-nat-gw feature. It makes the code more configurable, readable, and concise, and removes unnecessary steps and dependencies.

馃 Generated by Copilot at 81499b3

We're sailing on the Kubernetes sea
We're simplifying our workflow with ENABLE_NAT_GW
We're updating our Makefile and our e2e test
We're heaving on the line, one, two, three, and rest

HOW

馃 Generated by Copilot at 81499b3

  • Simplify workflow steps by installing Kube-OVN and vpc-nat-gw in one command with ENABLE_NAT_GW flag (link)
  • Introduce MULTUS_VERSION variable to specify and use consistent version of Multus CNI in workflow and image tag (link)
  • Remove redundant kind-untaint-control-plane dependencies from kind-install-vpc-nat-gw and kind-install-lb-svc targets in Makefile (link, link)
  • Add resource names to ginkgo.By messages in setupVpcNatGwTestEnvironment function in test/e2e/iptables-vpc-nat-gw/e2e_test.go (link)
  • Replace hardcoded .kube-system suffix with framework.KubeOvnNamespace variable in ovn_eip package in test/e2e/iptables-vpc-nat-gw/e2e_test.go (link, link, link)
  • Add ginkgo.By message to indicate overlay subnet retrieval in ovn_eip package in test/e2e/iptables-vpc-nat-gw/e2e_test.go (link)

@zhangzujian zhangzujian merged commit 976a32b into kubeovn:master Jul 24, 2023
58 checks passed
@zhangzujian zhangzujian deleted the fix-ci branch July 24, 2023 01:33
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jul 24, 2023
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jul 24, 2023
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants