Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes in e2e #3094

Merged
merged 3 commits into from Jul 31, 2023
Merged

some fixes in e2e #3094

merged 3 commits into from Jul 31, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 30, 2023

What type of this PR

  • Tests

Which issue(s) this PR fixes:

  1. reduce possiblilty of the same name suffix;
  2. fix e2e logging.

WHAT

馃 Generated by Copilot at 8cc27de

The pull request improves the reliability, readability, and quality of the e2e test cases for kube-ovn by using random ports and names, enhancing log messages, and fixing minor bugs and code smells in the test packages. The changes affect the files service.go, subnet.go, underlay.go, e2e_test.go, and util.go.

馃 Generated by Copilot at 8cc27de

Sing, O Muse, of the valiant pull request
That enhanced the test code of the framework
With random suffixes and ports, and log messages
That shone like the bright stars in the night sky.

HOW

馃 Generated by Copilot at 8cc27de

  • Increase the length of the random suffix for resource names to avoid conflicts (link)
  • Use a random port between 8000 and 8999 for service tests to avoid port conflicts (link)
  • Improve the log messages for creating and deleting provider networks in various packages (link, link, link, link, link, link, link, link)
  • Fix the bug of checking the IPv6 cluster IP in the ipvsadm output by using field-based matching instead of string contains (link)
  • Remove the redundant and unused assignment of the podName variable in the subnet package (link)
  • Change the DstIPs field in the NatOutGoingPolicyMatch struct to use a non-reserved IP range (link)
  • Simplify and clarify the code for generating the asName variable in the underlay package by using strings.ReplaceAll and a constant format string (link)

1. reduce possiblilty of the same name suffix;
2. fix e2e logging.
@zhangzujian zhangzujian marked this pull request as ready for review July 30, 2023 13:07
@zhangzujian zhangzujian merged commit a7e7a83 into kubeovn:master Jul 31, 2023
58 checks passed
@zhangzujian zhangzujian deleted the fix-e2e branch July 31, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants