Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes in e2e #3116

Merged
merged 1 commit into from Aug 7, 2023
Merged

some fixes in e2e #3116

merged 1 commit into from Aug 7, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Aug 5, 2023

What type of this PR

  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

馃 Generated by Copilot at c52f15b

Add namespace support to various e2e testing framework components and improve event message checks and subnet status updates in the e2e tests and controller.

馃 Generated by Copilot at c52f15b

We're testing the network in different namespaces
We're creating and managing resources with ease
We're quoting the values and checking the events
Heave away, me code-ies, heave away

HOW

馃 Generated by Copilot at c52f15b

  • Extend various resource client types with a namespace field to store the namespace of the resources (link, link, link, link, link, link, link, link, link)
  • Modify the corresponding constructor functions to assign the namespace field with the given namespace parameter (link, link, link, link, link, link, link, link, link)
  • Use the namespace field instead of the framework namespace to filter or wait for the resources in the WaitToHaveEvent, WaitForRunning, and WaitForNotFound functions (link, link)
  • Modify the event messages for subnet gateway type and node changes to use %q instead of %s to quote the values and avoid confusion with spaces or special characters (link)
  • Modify the tests for subnet gateway type and node changes to use %q instead of %s to match the event message format and use exact equality instead of substring containment to check the event message (link, link)
  • Add the waitSubnetStatusUpdate function to the underlay package to wait for the subnet status to reflect the expected number of using IPs in the given namespace (link)
  • Call the waitSubnetStatusUpdate function in various tests for pod IP allocation in the underlay mode to verify that the subnet status is updated correctly after creating or deleting pods in different subnets, nodes, or annotations (link, link, link, link, link, link, link, link, link)

@zhangzujian zhangzujian added the test automation tests label Aug 5, 2023
@zhangzujian zhangzujian marked this pull request as ready for review August 5, 2023 06:07
@zhangzujian zhangzujian merged commit 02f8c63 into kubeovn:master Aug 7, 2023
59 checks passed
@zhangzujian zhangzujian deleted the fix-e2e branch August 7, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant