fix: externalID map should not include external_ids #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xujunjie-cover <xujunjielxx@163.com>
bobz965
approved these changes
Nov 7, 2023
|
@xujunjie-cover please fix the DCO by |
xujunjie-cover
force-pushed
the
issue3377
branch
from
f94510b
to
051ca42
Compare
oilbeater
pushed a commit
that referenced
this pull request
Nov 7, 2023
Signed-off-by: xujunjie-cover <xujunjielxx@163.com>
bobz965
pushed a commit
that referenced
this pull request
Nov 8, 2023
Signed-off-by: xujunjie-cover <xujunjielxx@163.com>
bobz965
pushed a commit
to bobz965/kube-ovn
that referenced
this pull request
Nov 15, 2023
Signed-off-by: xujunjie-cover <xujunjielxx@163.com> Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #3377
WHAT
馃 Generated by Copilot at f94510b
Simplify the external_ids key format for logical switch ports associated with security groups in
pkg/controller/security_group.go. This improves code readability and consistency.馃 Generated by Copilot at f94510b
HOW
馃 Generated by Copilot at f94510b