Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix dpdk jobs #3405

Merged
merged 1 commit into from
Nov 13, 2023
Merged

ci: fix dpdk jobs #3405

merged 1 commit into from
Nov 13, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Nov 13, 2023

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

WHAT

馃 Generated by Copilot at c5a5663

This pull request adds support for building and using a dpdk image for the kube-ovn project. It modifies the .github/workflows/build-x86-image.yaml file to optimize the workflow for pull request events, and it adds new targets to the Makefile for the dpdk image.

馃 Generated by Copilot at c5a5663

Sing, O Muse, of the skillful pull request
That optimized the workflow of the build
And spared the steps of dpdk base images
When triggered by a pull request event.

HOW

馃 Generated by Copilot at c5a5663

  • Add a new target to build the dpdk image using the dpdk base image as a base image, and tag it with the release tag and the dpdk suffix (link, link)
  • Add a new step to the workflow to build and upload the dpdk image to artifact using the Makefile target (link, link)
  • Add a new target to save the dpdk image into a tar file (link)
  • Remove the redundant tag for the dpdk base image (link)
  • Skip downloading, loading, and uploading dpdk base images when the workflow is triggered by a pull request, since they are not needed for testing or reviewing the pull request (link, link, link)

@zhangzujian zhangzujian added the ci label Nov 13, 2023
@zhangzujian zhangzujian force-pushed the fix-ci-dpdk branch 8 times, most recently from 8a867bd to f18c539 Compare November 13, 2023 09:12
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian merged commit f7e2160 into kubeovn:master Nov 13, 2023
59 checks passed
@zhangzujian zhangzujian deleted the fix-ci-dpdk branch November 13, 2023 12:58
bobz965 pushed a commit that referenced this pull request Nov 14, 2023
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Nov 15, 2023
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Nov 15, 2023
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants