Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
馃 Generated by Copilot at a093a5a
This pull request adds and improves features for the ovn interconnection (ovn-ic) between OVN clusters. It updates the
Makefile
and thekind.yaml.j2
template to enable ovn-ic in the kind environment. It adds new methods and parameters to theovs
package for managing logical router policies and logical switch ports based on external IDs. It modifies thecontroller
package to use the new methods and parameters and to handle different CIDR formats and route options. It also fixes some format, error, and duplication issues in the code. It adds a new constantOvnICNone
to theutil
package.馃 Generated by Copilot at a093a5a
HOW
馃 Generated by Copilot at a093a5a
DeleteLogicalSwitchPorts
method to delete logical switch ports by external IDs and filter function (link, link, link)GetLogicalRouterPoliciesByExtID
method to get logical router policies by external ID key and value (link, link, link)ListLogicalRouterPolicies
method to addignoreExtIDEmptyValue
parameter and use it to filter policies by external IDs (link, link, link, link, link, link, link)AddLogicalRouterPolicy
method to compare external IDs of existing policies and avoid duplicates (link)DeleteLogicalRouterPolicies
method to addignoreExtIDEmptyValue
parameter and pass it toListLogicalRouterPolicies
method (link)ListLogicalRouterStaticRoutesByOption
method to check option key existence in route options (link)removeInterConnection
method to delete logical switch ports and logical router ports by external ID and filter function (link)establishInterConnection
method to create multiple transit switches for each group of gateway nodes and use chassis name for logical patch port name (link)establishInterConnection
method to move az name setting logic and remove redundant logical switch port check (link)acquireLrpAddress
method to add transit switch name parameter and more error information (link)startOvnIC
method to rename it tostartOVNIC
and change error handling logic (link)stopOvnIC
method to rename it tostopOVNIC
and change error handling logic (link)delLearnedRoute
method to handle nil policy and use policy variable instead of pointer (link, link)SynRouteToPolicy
method to add a call tosyncOneRouteToPolicy
method withOvnICNone
tag (link)syncOneRouteToPolicy
method to useGetLogicalRouterPoliciesByExtID
method and string set for policy routes (link, link)getTSCidr
method to usesubnetsLister
to get default logical switch subnet and protocol (link)ovs
package import statement (link)deletePolicyRouteForLocalDNSCacheOnNode
method to addignoreExtIDEmptyValue
parameter and pass it toListLogicalRouterPolicies
method (link)deletePolicyRouteForU2OInterconn
method to addignoreExtIDEmptyValue
parameter and pass it toListLogicalRouterPolicies
method (link)handleAddOrUpdateVpc
method to addignoreExtIDEmptyValue
parameter and pass it toListLogicalRouterPolicies
method (link)ovn_ic
variable to indicate whether ovn-ic feature is enabled and pass it tokind-init
andkind-generate-config
targets (link)kind-install-ovn-ic
target (link)gateway_node_name
variable format to use semicolon instead of comma forkind-install-ovn-ic
target and ovn-ic yaml template file (link, link, link)OvnICNone
constant to represent empty ovn-ic tag value (link)kind.yaml.j2
template file to support ovn-ic feature in kind environment (link, link)ovn_ic
variable and set default value of "false" (link)ovn_ic
is "true" (link)