Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add static route for custom vpc when create subnet with U2OInterconnection. #3462

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

xujunjie-cover
Copy link
Member

@xujunjie-cover xujunjie-cover commented Nov 27, 2023

[U2OInterconnection.](fix: add static route for custom vpc when create subnet with U2OInterconnection.)

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #3446

WHAT

馃[deprecated] Generated by Copilot at d8a6584

This pull request enhances the subnet controller to support multiple VPCs and static routes. It allows subnets in different VPCs to communicate with each other through the underlay network. It updates the subnet.go file with new functions and logic for managing the static route operations.

馃[deprecated] Generated by Copilot at d8a6584

We're sailing on the cloud with multiple VPCs
We need to interconnect them with static routes
So haul away the subnet controller and make it work
One, two, three, heave ho, and update the underlay

HOW

馃[deprecated] Generated by Copilot at d8a6584

  • Add or delete static routes for underlay to overlay subnet interconnection when creating, updating, or deleting subnets (link, link, link)
  • Define helper functions addStaticRouteForU2OInterconn and deleteStaticRouteForU2OInterconn in pkg/controller/subnet.go (link)

U2OInterconnection.

Signed-off-by: xujunjie-cover <xujunjielxx@163.com>
@oilbeater
Copy link
Collaborator

@xujunjie-cover please fix the lint issue

@oilbeater oilbeater merged commit b1de14c into kubeovn:master Nov 28, 2023
58 of 59 checks passed
oilbeater pushed a commit that referenced this pull request May 28, 2024
U2OInterconnection.

Signed-off-by: xujunjie-cover <xujunjielxx@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

銆恥2o銆慤nderlay network in custom vpc can't reroute to physical gw when set u2o.
2 participants