Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete vm's lsp and release ipam.ip #3476

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

lynn901
Copy link
Member

@lynn901 lynn901 commented Nov 30, 2023

Signed-off-by: yuanliu@cmss.chinamobile.com yuanliu@cmss.chinamobile.com

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

delete vm's lsp and release ipam.ip

Which issue(s) this PR fixes

Fixes #(issue-number)

WHAT

馃[deprecated] Generated by Copilot at 85716e6

Improved pod controller logic by using podKey for switch ports and IPAM. This avoids potential conflicts or errors with pod names or namespaces.

馃[deprecated] Generated by Copilot at 85716e6

Oh, we are the pod controllers, and we work on the code
We refactor and we test it, and we make it run in mode
We use the podKey now, to identify the ports
And IPAM operations, are consistent of course

HOW

馃[deprecated] Generated by Copilot at 85716e6

  • Introduce podKey variable to use pod namespace and name as key for pod-related operations (link, link, link)
  • Use podKey to list logical switch ports associated with pod in pkg/controller/pod.go (link)
  • Use podKey to get and release pod address from IPAM module in pkg/controller/pod.go (link, link)

Signed-off-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>
@bobz965 bobz965 merged commit 6233434 into kubeovn:master Nov 30, 2023
59 checks passed
@bobz965 bobz965 added bug Something isn't working need backport labels Nov 30, 2023
@bobz965
Copy link
Collaborator

bobz965 commented Nov 30, 2023

backport to 1.12 1.11

bobz965 pushed a commit that referenced this pull request Nov 30, 2023
Signed-off-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>

Co-authored-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>
bobz965 pushed a commit that referenced this pull request Nov 30, 2023
Signed-off-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>

Co-authored-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>
@lynn901 lynn901 deleted the fix_delete_vm_lsp branch November 30, 2023 02:39
bobz965 pushed a commit that referenced this pull request Nov 30, 2023
Signed-off-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>

Co-authored-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965 pushed a commit that referenced this pull request Dec 1, 2023
Signed-off-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>

Co-authored-by: yuanliu@cmss.chinamobile.com <yuanliu@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants