fix chassis gc #3525
Merged
fix chassis gc #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
bobz965
reviewed
Dec 14, 2023
| if err != nil { | ||
| klog.Errorf("failed to get node %s chassis: %s, %v", node.Name, annoChassisName, err) | ||
| return err | ||
| } | ||
| if chassis == nil { |
There was a problem hiding this comment.
这里如果有多个chassis 或者 只有一个chassis 但是和 node name不一致，直接触发 gc。
There was a problem hiding this comment.
节点被删除时，chassis 会被删除，但 ovn-controller 还会自动注册一个 chassis，这个 chassis 没有 external-ids:vendor=kube-ovn。后续如果一个同名且同 IP 的节点加入集群，ovn-controller 无法注册新的 chassis。
There was a problem hiding this comment.
那就是说两种情况：
- 你说的这种，node之前被清理了，但是 ovn-controller 还在跑或者重新跑，导致有脏记录。 这种node不存在，但是有多余的chassis，现在你的 gcChassis 已经覆盖到了。 但是 node 更新的时候触发gc的逻辑还是有问题，目前没触发到。
- 我清理了整个集群，想快速重建下kube-ovn，可能会出现有两个chassis的情况
bobz965
reviewed
Dec 14, 2023
| if err != nil { | ||
| klog.Errorf("failed to get node %s chassis: %s, %v", node.Name, annoChassisName, err) | ||
| return err | ||
| } | ||
| if chassis == nil { |
There was a problem hiding this comment.
这里如果有多个chassis 或者 只有一个chassis 但是和 node name不一致，直接触发 gc。
bobz965
approved these changes
Dec 14, 2023
zhangzujian
added a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
🤖[deprecated] Generated by Copilot at 6904498
Refactor and improve chassis management in
gc.goandnode.go. Enhance performance, reliability, and compatibility of garbage collection and chassis tag update functions.🤖[deprecated] Generated by Copilot at 6904498
HOW
🤖[deprecated] Generated by Copilot at 6904498
ListChassismethod to get all chassis instead of filtering by vendor tag (link)chassisNodesmap after finding matching node (link)chassisNodesmap and delete chassis that are not in use by any node (link)GetChassismethod withkubeovnOnlyparameter set to true to get chassis withkube-ovnvendor tag (link)gcChassisfunction and return error if chassis is not registered for node (link)