delete lsp and ipam with ip #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz965
force-pushed
the
ip-delete-ipam-and-lsp
branch
4 times, most recently
from
ca66100
to
6c2909d
Compare
lynn901
approved these changes
Dec 19, 2023
bobz965
force-pushed
the
ip-delete-ipam-and-lsp
branch
from
6c2909d
to
67d9dc3
Compare
bobz965
force-pushed
the
ip-delete-ipam-and-lsp
branch
3 times, most recently
from
e352ca1
to
6edf107
Compare
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965
force-pushed
the
ip-delete-ipam-and-lsp
branch
from
6edf107
to
29779d5
Compare
oilbeater
reviewed
Dec 21, 2023
oilbeater
approved these changes
Dec 21, 2023
bobz965
added a commit
that referenced
this pull request
Dec 21, 2023
* delete lsp and ipam with ip * refresh sg after delete ip lsp --------- Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965
added a commit
that referenced
this pull request
Dec 22, 2023
* delete lsp and ipam with ip * refresh sg after delete ip lsp --------- Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965
added a commit
that referenced
this pull request
Mar 22, 2024
* delete lsp and ipam with ip * refresh sg after delete ip lsp --------- Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
1.1 基于 multus 多网卡 NAD 维护，用户换了一个子网，由于 multus network-attachment-definition 的设计在使用多网卡时十分灵活。如果 IP 删除而 lsp 保留则会导致无法新建同名的 lsp。这种 ip 会直接走 changeVMSubnet 逻辑直接删除重建。
1.2 基于 multus 多网卡 NAD 维护，用户移除了一个子网，这种 ip 要在pod annos变更之后， 手动删除该 IP
用户关机 --> 删除 ipcr --> 开机： 这个场景会创建新的 IP
参考：
在 openstack neutron 的设计中：
neutron 设计了一个 port 的数据库表，用于直接维护 ip 以及 安全组，地址对 ip 等信息。
目前 kube-ovn 的 IP 的业务逻辑十分简单。 可以考虑将一些 IP 相关的资源的逻辑 IP中去。
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough