Fix 1.12 ipam deletion #3554
Merged
Fix 1.12 ipam deletion #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oilbeater , 和 1.11 合入的那个一致 |
bobz965
force-pushed
the
fix-1.12-ipam-deletion
branch
2 times, most recently
from
d91b488
to
dbb0193
Compare
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965
force-pushed
the
fix-1.12-ipam-deletion
branch
from
dbb0193
to
6fcbdb6
Compare
oilbeater
approved these changes
Dec 21, 2023
bobz965
added a commit
that referenced
this pull request
Dec 21, 2023
* fix ipam deletion * fix: change vm subnet --------- Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965
added a commit
that referenced
this pull request
Dec 22, 2023
* fix ipam deletion * fix: change vm subnet --------- Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
bobz965
added a commit
that referenced
this pull request
Mar 22, 2024
* fix ipam deletion * fix: change vm subnet --------- Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
handleAddPod: 将 IP CR 的创建放在 create LSP （会校验冲突）之后
handleDeletePod: 如果不保留 ip，则将 LSP，ip，ipam，sg 一并删除。
changeVMSubet: 多网卡可能误删除，虽然后续会重建出来。但是可能影响未变更网卡的网络。
Bug fixes
#3181
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough