delete cm ovn-ic-config cause crash 1.11 #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add ovn-ic-controller.log to hostpath Signed-off-by: Changlu Yi <clyi@alauda.io>
changluyi
changed the title
oilbeater
requested changes
Jan 24, 2024
| @@ -117,19 +117,22 @@ func (c *Controller) resyncInterConnection() { | |||
| return | |||
| } | |||
| klog.Info("start to remove ovn-ic") | |||
| azName := "" | |||
| icDBHost := "" | |||
| var azName, icDBHost, icSBPort, icNBPort string | |||
There was a problem hiding this comment.
是不是直接 disable 就可以了，不续要下面的配置
There was a problem hiding this comment.
disableOVNIC需要这些配置去初始化c.ovnLegacyClient.OvnICSbAddress，c.ovnLegacyClient.OvnICNbAddress
是不是直接 disable 就可以了，不续要下面的配置
Signed-off-by: Changlu Yi <clyi@alauda.io>
oilbeater
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough