Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil pointer dereference #3951

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix nil pointer dereference #3951

merged 2 commits into from
Apr 25, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

E0424 00:00:25.512483       1 runtime.go:79] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
goroutine 1187 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic({0x562b6331e660, 0x562b64afdd10})
	k8s.io/apimachinery@v0.29.4/pkg/util/runtime/runtime.go:75 +0x85
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc000711b60?})
	k8s.io/apimachinery@v0.29.4/pkg/util/runtime/runtime.go:49 +0x6b
panic({0x562b6331e660?, 0x562b64afdd10?})
	runtime/panic.go:770 +0x132
github.com/kubeovn/kube-ovn/pkg/controller.(*Controller).handleAddOrUpdateVpc(0xc0006c5208, {0xc000d4ac20, 0xb})
	github.com/kubeovn/kube-ovn/pkg/controller/vpc.go:347 +0x1190
github.com/kubeovn/kube-ovn/pkg/controller.(*Controller).processNextAddVpcWorkItem.func1(0xc0006c5208, {0x562b631a0540, 0xc000711b60})
	github.com/kubeovn/kube-ovn/pkg/controller/vpc.go:1004 +0x194
github.com/kubeovn/kube-ovn/pkg/controller.(*Controller).processNextAddVpcWorkItem(0xc0006c5208)
	github.com/kubeovn/kube-ovn/pkg/controller/vpc.go:1010 +0x4c

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian added bug Something isn't working need backport labels Apr 25, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian marked this pull request as ready for review April 25, 2024 07:05
@zhangzujian zhangzujian merged commit e56a636 into kubeovn:master Apr 25, 2024
62 checks passed
@zhangzujian zhangzujian deleted the fix-nil branch April 25, 2024 07:26
zhangzujian added a commit that referenced this pull request Apr 25, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit that referenced this pull request Apr 25, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
bobz965 pushed a commit that referenced this pull request Apr 26, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants