chart: fix kubeVersion to allow for patterns that match sub versions #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Hill-Grannec <joachim.hill@gmail.com>
josmo
force-pushed
the
fix-helm-kubeversion
branch
from
796d79d
to
823b4a4
Compare
zhangzujian
approved these changes
May 3, 2024
zhangzujian
pushed a commit
that referenced
this pull request
May 3, 2024
…3975) Signed-off-by: Joachim Hill-Grannec <joachim.hill@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
May 7, 2024
…3975) Signed-off-by: Joachim Hill-Grannec <joachim.hill@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Similar to other charts that don't add the -0 for kubeversion, it then breaks deployments and upgrades for environments like eks where the kube version will look like "v1.25.13-eks-43840fb". This will allow subversion to be accepted durring installs and upgrades for the chart.