fix lsp not updating addresses #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
oilbeater
approved these changes
May 13, 2024
|
We need to add this to e2e tests later |
zhangzujian
added a commit
that referenced
this pull request
May 13, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
May 13, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Which issue(s) this PR fixes
In step 5, the recreated pod will never be running, because the LSP's addresses field is not updated.
This patch is a simple fix. Maybe we should record pod uid in the LSP's external-ids.