Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: set entrypoint to dumb-init #4018

Merged
merged 2 commits into from
May 14, 2024

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented May 14, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

When kube-ovn-conttoller is stopped, the kube-ovn-controller process cannot receive the terminal signal, and the pod keeps in Terminating state until reaching terminationGracePeriodSeconds which is 30s by default.

I0514 02:03:35.241908      29 pod.go:428] take 0 ms to handle sync pod underlay-3836/pod-106582449
I0514 02:03:45.291513      29 endpoint.go:107] update add/update endpoint kube-system/kube-ovn-controller
Log file created at: 2024/05/14 02:04:15
Running on machine: kube-ovn-control-plane
Binary: Built with gc go1.22.3 for linux/amd64
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
I0514 02:04:15.949157      29 config.go:308] no --kubeconfig, use in-cluster kubernetes config
I0514 02:04:15.949652      29 k8s.go:27] succeeded to dial apiserver "10.96.0.1:443"
I0514 02:04:15.951865      29 config.go:366] no --kubeconfig, use in-cluster kubernetes config
I0514 02:04:15.952497      29 config.go:300] config is ...
I0514 02:04:15.967558      29 leaderelection.go:250] attempting to acquire leader lease kube-system/kube-ovn-controller...
I0514 02:04:48.654858      29 leaderelection.go:260] successfully acquired lease kube-system/kube-ovn-controller

@zhangzujian zhangzujian marked this pull request as ready for review May 14, 2024 05:18
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian merged commit a57d041 into kubeovn:master May 14, 2024
61 of 62 checks passed
@zhangzujian zhangzujian deleted the add-dumb-init branch May 14, 2024 06:09
zhangzujian added a commit that referenced this pull request May 14, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@fanriming
Copy link
Member

Should we explicitly specify /usr/bin/dumb-init in the k8s instance declaration? Since the entrypoint of the image is overwritten by the command field of the k8s instance, it is also possible to use the args field parameter directly.

bobz965 pushed a commit that referenced this pull request May 15, 2024
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants