Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service account missing in deployment-check #361

Closed
NissesSenap opened this issue Mar 16, 2020 · 1 comment
Closed

service account missing in deployment-check #361

NissesSenap opened this issue Mar 16, 2020 · 1 comment
Assignees
@jonnydawg
Labels
feature request A request for a specific feature to be added to Kuberhealthy

Comments

@NissesSenap
Copy link
Contributor

Describe the feature you would like and why you want it
I need the possibility to add a service account to the deployment that that deployment-check creates through the khchecks.comcast.github.io deployment or something similar.

Additional context
I'm using openshift and due to the extra security context i need to be able to set a service account that got the possibility to create containers that runs as root user. The pod is currently started with the default serviceaccount and if i patch it, it get's replaced by the operator.
@NissesSenap NissesSenap added the feature request A request for a specific feature to be added to Kuberhealthy label Mar 16, 2020
@NissesSenap NissesSenap mentioned this issue Mar 16, 2020
Merged
@jonnydawg jonnydawg self-assigned this Mar 16, 2020
@jonnydawg
Copy link
Collaborator

Thanks for the work! Your PR was merged :)

NissesSenap added a commit to NissesSenap/kuberhealthy that referenced this issue Apr 18, 2020
@NissesSenap
Adding CHECK_SERVICE_ACCOUNT env to dpeloyment
ea9f5bd 
This to enable people to know about the feature.
Forgot to do it in: kuberhealthy#361
NissesSenap added a commit to NissesSenap/kuberhealthy that referenced this issue Apr 18, 2020
@NissesSenap
Adding CHECK_SERVICE_ACCOUNT to khcheck deployment
694a1af 
Should have done this in kuberhealthy#361 but forgot.
This way people don't have to read the code to know about this setting.
The default SA is the default account that will be used by default so
this won't matter for anyone who dosen't want to overwrite it like me..
@NissesSenap NissesSenap mentioned this issue Apr 18, 2020
Merged
calmkart pushed a commit to calmkart/kuberhealthy that referenced this issue Apr 29, 2020
@NissesSenap @calmkart
Adding CHECK_SERVICE_ACCOUNT to khcheck deployment
8e8c841 
Should have done this in kuberhealthy#361 but forgot.
This way people don't have to read the code to know about this setting.
The default SA is the default account that will be used by default so
this won't matter for anyone who dosen't want to overwrite it like me..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonnydawg jonnydawg

Labels
feature request A request for a specific feature to be added to Kuberhealthy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnydawg @NissesSenap