Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding env variables in check-reaper #768

Closed
AshutoshNirkhe opened this issue Jan 3, 2021 · 2 comments
Closed

Allow overriding env variables in check-reaper #768

AshutoshNirkhe opened this issue Jan 3, 2021 · 2 comments
Labels
feature request A request for a specific feature to be added to Kuberhealthy

Comments

@AshutoshNirkhe
Copy link
Contributor

AshutoshNirkhe commented Jan 3, 2021

Describe the feature you would like and why you want it
Currently env variables used in check reaper template are hard-coded as in,
MAX_PODS_THRESHOLD - https://github.com/Comcast/kuberhealthy/blob/master/deploy/helm/kuberhealthy/templates/check-reaper.yaml#L32
JOB_DELETE_TIME_DURATION - https://github.com/Comcast/kuberhealthy/blob/master/deploy/helm/kuberhealthy/templates/check-reaper.yaml#L34

Some checks (like daemonset check) keeps a lot of pods in Completed state which basically eats IPs. If we could reduce(override) these values, it will be really useful.

Additional context
In general, I have observed some hard-coded values (which actually are set through variables in templates in most cases but) not exposed through values.yaml file which makes it a bit to difficult to customize things. I have opened few other issues like #766 , #760 etc. Allowing customizing the checks behaviors wherever possible will make them more usable IMHO. Thanks!

@AshutoshNirkhe AshutoshNirkhe added the feature request A request for a specific feature to be added to Kuberhealthy label Jan 3, 2021
AshutoshNirkhe added a commit to AshutoshNirkhe/kuberhealthy that referenced this issue Jan 4, 2021
@AshutoshNirkhe
Copy link
Contributor Author

Raised #769

@joshulyne
Copy link
Collaborator

This makes sense, merged in #769! Closing this issue for now, but will keep your other issue #766! Feel free to submit prs as you see fit! Thank you!! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a specific feature to be added to Kuberhealthy
Projects
None yet
Development

No branches or pull requests

2 participants