issue 380 - env check for start time #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
integrii
requested changes
Mar 26, 2020
There was a problem hiding this comment.
It looks like we only update the RunStartTime on the creation of a KuberhealthyCheck and it also isn't completely aligned with how Kuberhealthy determines that a check has timed out.
However, we probably don't even need a struct property for RunStartTime. We should find a codepath wherein we use the same variable that is used for measuring when the check has timed out. This way they are in complete alignment.
If you want to review, let me know on Slack and we'll talk it over.
integrii
approved these changes
Mar 26, 2020
|
Worked with @2infinitee to rework this slightly today. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to issue 380, this is setting start time as an environment variable.