Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create docs for deploy directory #403

Merged
merged 2 commits into from Apr 6, 2020
Merged

create docs for deploy directory #403

merged 2 commits into from Apr 6, 2020

Conversation

integrii
Copy link
Collaborator

@integrii integrii commented Apr 2, 2020

documentation for the deploy dir files to make install less confusing

@integrii integrii requested a review from 2infinitee April 2, 2020 00:28
@integrii integrii self-assigned this Apr 2, 2020
@integrii integrii added this to the 2.2.0 milestone Apr 2, 2020
@2infinitee
Copy link
Collaborator

@integrii I think it's pretty straight forward how you have it at the moment. I think it can be more consistent and organized.

As for the Helm portion of it, it's interesting how you are using Helm. I think it would be easier to provide avalues.yaml files for each configuration (w/ prometheus operator, prometheus, or no prometheus). Can tell you more about it.

2infinitee
2infinitee approved these changes Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@2infinitee 2infinitee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve and we can improve deployment docs and methods in another issue as a feature.

@integrii integrii merged commit 52d1979 into master Apr 6, 2020
@integrii integrii deleted the deploy-docs branch June 5, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2infinitee 2infinitee 2infinitee approved these changes

Assignees

@integrii integrii

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@integrii @2infinitee