go mod download for faster Dockerfile #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloading all dependencies before ading the code. This enabels the docker cache to do it's magic.
|
@integrii please have a look and see what you think. |
|
Looks fine to me as long as the build still works with this new Thank you for looking at Kuberhealthy so seriously. We appreciate all your contributions a lot. |
Using the same logic as the rest. Could still clean up this one a bit, no need to do the move for example. To lazy to fix right now.
|
Thank, glad that I can help with something I feel comfortable doing. I have updated the rest of the Dockerfiles and I hope I managed to get them all right. |
|
I've also been able to test some of the Dockerfiles you changed, and they lgtm! Haven't been able to test all of them though -- will try and do that soon! |
integrii
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod download will help to download all dependencies before coping over the code. This won't help allot in your local environment but if you run this in a CI/CD pipeline you will see a increase if you run the build multiple time at the same server due to docker caching.
Since go creates a bin and the COPY command sets the owner to the current user we don't have to do any chown until the bin is ready.
I assume that dockerhub should still be happy with the dockerfile since we are using USER in the final container.
I only did this update in one file, if you think this is a good idea i will do it in the rest of them.