Daemonst removal of hardcoded runAsUser #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current runAsUser := 1000 creates issues when running in OCP. If we assume that the user is set to none root in our checks we can just grab that user ID and use that in the DS that is created. This will also work with runAsUser set in a standard k8s env or just running it as a container since we have set 999 as the default user in the containers.
2infinitee
approved these changes
Apr 23, 2020
integrii
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current runAsUser := 1000 creates issues when running in OCP.
If we assume that the user is set to none root in our checks
we can just grab that user ID and use that in the DS that is created.
Still have the default value in there if we for some reason can't find the id of the current user.
This will also work with runAsUser set in a standard k8s env or just
running it as a container since we have set 999 as the default user in
the containers.