Update deployment check time limit #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrii
requested changes
May 4, 2020
integrii
reviewed
May 13, 2020
Comment on lines
-53
to
+54
| // Calculate check run duration from the deadline and now | ||
| deadline, err := strconv.Atoi(unixDeadline) | ||
| if err != nil { | ||
| log.Fatalln("Failed to parse unix deadline from environment.") | ||
| } | ||
| if deadline > 0 { | ||
| log.Println("Parsed check deadline time from the environment:", deadline) | ||
| timeLimit = time.Duration((int64(deadline) - time.Now().Unix()) * 1e9) // Multiply by 1,000,000,000 because that's how many nanoseconds are in a second | ||
| } | ||
| timeLimit = timeDeadline.Sub(time.Now().Add(time.Second * 5)) | ||
| log.Println("Check time limit set to:", timeLimit) |
integrii
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtract 5s from time-limit;bump version
Subtracts 5s from the time limit to ensure that the check reports its last stage before timing out.
Bumps the version up a patch number.