Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kuberhealthy-client npm package to readme #476

Merged
merged 2 commits into from May 15, 2020

Conversation

gWOLF3
Copy link
Contributor

@gWOLF3 gWOLF3 commented May 14, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 14, 2020

CLA assistant check
All committers have signed the CLA.

@gWOLF3
Copy link
Contributor Author

gWOLF3 commented May 14, 2020

something seems broken with the CLA assistant? I've already signed.

@jonnydawg
Copy link
Collaborator

It seems like you may have made commits under a different email? You can resolve this by adding that email to your github account under settings!

@chadbitzer
Copy link
Collaborator

something seems broken with the CLA assistant? I've already signed.

@gWOLF3, I had the same issue and it was exactly as @jonnydawg stated, the signing email in github (personal) was different than the account I had committed with in git (work computer).

at cli, use "git config --list" to see the email linked to your commit.

Copy link
Collaborator

@jonnydawg jonnydawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@jonnydawg jonnydawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be super helpful seeing an example, if you could provide a simple one -- I think it would help with other contributors a lot!

@gWOLF3 gWOLF3 requested a review from jonnydawg May 15, 2020 03:57
Copy link
Collaborator

@jonnydawg jonnydawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jonnydawg jonnydawg merged commit 3426907 into kuberhealthy:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants