Image pull checker and eviction fix #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the following updates:
-Adds an external image pull check to the test-external-check
-Adds more in depth PodKill and PodNameExists functions to util package
-Updates cleanup function:
-Adds error return to evictPod function
-Adds static 30s grace period to evictPod function
-Checks for pods that are not in Failed or Succeeded state, instead of only Running state.
-If evictPod returns an error, run util.PodNameExists and if it returns true, run util.PodKill.
…est-external-check/README.md
|
|
This was
linked to
issues
Jun 9, 2020
joshulyne
reviewed
Jun 11, 2020
joshulyne
reviewed
Jun 11, 2020
joshulyne
reviewed
Jun 11, 2020
joshulyne
reviewed
Jun 11, 2020
|
@zjhans check the conflicts here and re-submit the PR... I really like your detailed and concise github descriptions. |
-Removes the temp fix from cmd/kuberhealthy/util.go and matches it to master -Makes verbiage updates and usage clarification to cmd/test-external-check/README.md -Replaces podExists function in pkg/checks/external/util/main.go with updated PodNameExists function from the util package
zjhans
force-pushed
the
image-pull-checker-and-eviction-fix
branch
from
d5757a5
to
d720ee9
Compare
…hecks/external/main.go
integrii
requested changes
Jun 17, 2020
…external/main.go by removing redundant logging.
…to the evictPod function to reduce nesting and improve readability and clarity.
…ure updates do not unintentionaly bypass this.
integrii
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves issues #221 and #473 with the following updates:
-Adds error return to evictPod function
-Checks for pods that are not in Failed or Succeeded state, instead of only Running state.
-If evictPod returns an error, run util.PodNameExists and if it returns true, run util.PodKill,
returning any errors