Add python-client #523
Merged
Add python-client #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com>
|
|
|
This is great. Thank you for contributing to Kuberhealthy and adding a nice example for Python programmers to get started. You may want to also add a check on the writing your own checks page. @jonnydawg is taking a look more deeply at this for feedback. |
jonnydawg
requested changes
Jun 16, 2020
Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com>
Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com> Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com>
Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com> Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com>
Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com> Signed-off-by: Babak Ghadiri <bghadiri@hamravesh.com>
jonnydawg
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python-client has been added by following JavaScript client codes.
It's better to make a PyPi library from it and publish that by your (kuberhealthy) credentials for making it more easier to use.
Signed-off-by: Babak Ghadiri bghadiri@hamravesh.com