Fix go routine leak and refactor concurrency on external checks #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not only is the memory leak gone, but memory use overall looks much lower after this PR...
|
jonnydawg
reviewed
Jul 7, 2020
integrii
commented
Jul 7, 2020
integrii
changed the title
joshulyne
reviewed
Jul 9, 2020
joshulyne
reviewed
Jul 9, 2020
joshulyne
approved these changes
Jul 10, 2020
jonnydawg
reviewed
Jul 10, 2020
| case <-sawRemovalChan: // we saw the watched pod remove | ||
| case <-ctx.Done(): // graceful shutdown signal | ||
| ext.log("pod shutdown monitor stopping gracefully") | ||
| case <-ext.waitForDeletedEvent(watcher): // we saw the watched pod remove |
There was a problem hiding this comment.
it's possible that waitForDeletedEvent(watcher) can return an error to this channel when a Watch.Error event occurs. In that case, should the we recreate the watcher and call waitForDeletedEvent(watcher) again?
There was a problem hiding this comment.
I think it's too hard to implement retries here because we won't know if the error is because the supplied watcher is completely closed, or some other condition. As long as we pass the error upstream, it's probably better to do the retry logic at a higher level in the code.
I have had bad experiences trying to make every thing that tries anything do retries...
added 2 commits
July 10, 2020 16:44
…hy into pr-fix-goroutine-leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a more inclusive fix for #537