Deployment check taint #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 28, 2020 15:28
jonnydawg
reviewed
Nov 6, 2020
jonnydawg
reviewed
Nov 6, 2020
jonnydawg
reviewed
Nov 6, 2020
jonnydawg
reviewed
Nov 6, 2020
jonnydawg
reviewed
Nov 6, 2020
jonnydawg
reviewed
Nov 6, 2020
jonnydawg
requested changes
Nov 6, 2020
jonnydawg
reviewed
Nov 11, 2020
jonnydawg
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included env variables and a new function to allow the ability to schedule the checker pods on dedicated nodes. Also modified the code to still take in blank values for those env variables to schedule anywhere as it does today. This has been tested in lab for both dedicated nodes as well as blank values which successfully schedules correctly for both circumstances.