Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: ServiceMonitor Endpoints specifications #731

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Helm: ServiceMonitor Endpoints specifications #731

merged 4 commits into from
Dec 1, 2020

Conversation

geoL86
Copy link
Contributor

@geoL86 geoL86 commented Nov 20, 2020

Helm: ServiceMonitor Endpoints specifications should be parametrised

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@geoL86 geoL86 mentioned this pull request Nov 20, 2020
Closed
joshulyne
joshulyne approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@joshulyne joshulyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks so much for taking this up!

@joshulyne
Copy link
Collaborator

ah theres a .ci/values.yaml that we use for our e2e tests that also needs the modification:

prometheus:
  enabled: false
  name: "prometheus"
  release: prometheus-operator
  serviceMonitor: false
  enableAlerting: false

joshulyne
joshulyne requested changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@joshulyne joshulyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more place to add the helm change!

@joshulyne joshulyne merged commit 49f175c into kuberhealthy:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshulyne joshulyne joshulyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geoL86 @CLAassistant @joshulyne