Deployment check tol fix #783
Conversation
go.sum
Outdated
| @@ -14,15 +14,20 @@ cloud.google.com/go/pubsub v1.0.1/go.mod h1:R0Gpsv3s54REJCy4fxDixWD93lHJMoZTyQ2k | |||
| cloud.google.com/go/storage v1.0.0/go.mod h1:IhtSnM/ZTZV8YYJWCY8RULGVqBDmpoyjwiyrjsg+URw= | |||
| dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU= | |||
| github.com/Azure/go-autorest/autorest v0.9.0/go.mod h1:xyHB1BMZT0cuDHU7I0+g046+BFDTQ8rEZB0s4Yfa6bI= | |||
| github.com/Azure/go-autorest/autorest v0.9.6 h1:5YWtOnckcudzIw8lPPBcWOnmIFWMtHci1ZWAZulMSx0= | |||
There was a problem hiding this comment.
why are there so many Azure packages added?
There was a problem hiding this comment.
I do not have answer for this. I do not believe I imported any new packages for this check revision
cmd/deployment-check/deployment.go
Outdated
| if splitEnvVars == nil { | ||
| err := errors.New("nil was entered into multiple toleration parser") | ||
| ReportFailureAndExit(err) | ||
| } |
There was a problem hiding this comment.
you do a check in the tolerationHandler func that makes sure the list has more than 1 item:
if len(splitEnvVars) > 1 { before you pass it in the multipleTolerations func.
so is this check if splitEnvVars == nil be necessary?
There was a problem hiding this comment.
I received feedback to always have something like this in to make sure that no one is abusing the function. I understand it is repetitive. Let me know how you want me to proceed.
There was a problem hiding this comment.
thats fair, i wasn't thinking that it was a function that could be reused! 👍
|
I am working on an edit right now |
Deployment check fix that now has the ability to accept multiple tolerations. Additionally, it now checks for the toleration to be null and does not create any tolerations. I have tested this in lab and has accepted 3 tolerations, single tolerations, and no tolerations. All tests passed and scheduled as expected.