fix: Set proper pod port where prometheus metrics are exposed #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
randrusiak
force-pushed
the
fix-prometheus-annotations
branch
from
9ccb70f
to
f8f1dc9
Compare
Signed-off-by: randrusiak <r.andrusiak@protonmail.com>
randrusiak
force-pushed
the
fix-prometheus-annotations
branch
from
f8f1dc9
to
20c5ed2
Compare
integrii
reviewed
Mar 29, 2021
| @@ -321,7 +321,7 @@ metadata: | |||
| namespace: kuberhealthy | |||
| annotations: | |||
| prometheus.io/scrape: "true" | |||
| prometheus.io/port: "80" | |||
| prometheus.io/port: "8080" | |||
There was a problem hiding this comment.
this will get regenerated by our build automation when the helm chart is updated - fyi
integrii
reviewed
Mar 29, 2021
| @@ -10,7 +10,7 @@ metadata: | |||
| annotations: | |||
| {{- if and .Values.prometheus.enabled (not .Values.prometheus.serviceMonitor.enabled) }} | |||
| prometheus.io/scrape: "true" | |||
| prometheus.io/port: "80" | |||
| prometheus.io/port: "8080" | |||
There was a problem hiding this comment.
@joshulyne can you verify 8080 is the right port here??
joshulyne
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, prometheus-server tries to scrape metrics from pod's port 80 which isn't exposed.
According to default prometheus kubernetes_sd_config service annotation
prometheus.io/portshould point to pod's port instead of service port.