ssl check refactor #879
Merged
ssl check refactor #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnydawg
reviewed
Apr 7, 2021
go.mod
Outdated
| @@ -12,6 +12,7 @@ require ( | |||
| github.com/google/uuid v1.1.1 | |||
| github.com/gophercloud/gophercloud v0.1.0 // indirect | |||
| github.com/gorhill/cronexpr v0.0.0-20180427100037-88b0669f7d75 | |||
| github.com/grantae/certinfo v0.0.0-20170412194111-59d56a35515b // indirect | |||
There was a problem hiding this comment.
i don't see grantae/certinfo imported anywhere in these changes -- just wondering where this indirect is needed
|
I am going to add debugging using the |
|
i ended up removing the |
jonnydawg
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug we saw wherein the SSL handshake test would sometimes fail and streamlines the code in the
ssl_utilpackage.