feat: optionally allow users to install pod restarts check with a clu… #897
Conversation
| - env: | ||
| - name: MAX_FAILURES_ALLOWED | ||
| value: "10" | ||
| image: kuberhealthy/pod-restarts-check:v2.3.3 |
There was a problem hiding this comment.
I'm not sure if I need to do anything with this tag? As this needs to points to a version that hasn't been released yet so maybe the release pipeline updates this?
There was a problem hiding this comment.
This one is actually manual... This is basically documentation. The versions in the helm chart (and the flat files in the directory with the helm chart) get updated after we change the version.yaml of the chart, but this one does not.
| @@ -192,6 +192,7 @@ check: | |||
| registry: kuberhealthy | |||
| repository: pod-restarts-check | |||
| tag: v2.3.3 | |||
There was a problem hiding this comment.
Same as above, I'm not sure if I need to do anything with this tag? As this needs to points to a version that hasn't been released yet so maybe the release pipeline updates this?
There was a problem hiding this comment.
I believe this version v2.3.3 has been released? https://hub.docker.com/repository/registry-1.docker.io/kuberhealthy/pod-restarts-check/tags?page=1&ordering=last_updated
hmm we don't have the best release process for specific versions for these external checks -- when a pr for external checks get merged in we do have a github action in place for build and pushing "latest". For specific versions, we build and push manually :/
There was a problem hiding this comment.
ok cool - makes sense, so is it best to change that to latest in this PR and let the followup PR set the correct tag?
There was a problem hiding this comment.
Yep... this is the flow I would expect:
- third party check makes a new release version
- third party check opens a PR to edit this values.yaml file for the helm chart
- helm chart static files are regenerated automatically
rawlingsj
force-pushed
the
master
branch
2 times, most recently
from
8530d00
to
3056bfc
Compare
…tream PR to be merged we can remove this check once upstream PR is merged kuberhealthy/kuberhealthy#897
…tream PR to be merged we can remove this check once upstream PR is merged kuberhealthy/kuberhealthy#897
…tream PR to be merged we can remove this check once upstream PR is merged kuberhealthy/kuberhealthy#897
…ster scope similar to this PR kuberhealthy#681
|
@rawlingsj thanks so much for contributing this! will check it out and test it soon! |
|
@rawlingsj upped the pod-restarts-check to |
…ster scope
similar to this PR #681