Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KKP User Cluster Management with Terrafrom Rest API and Cluster CRDs #111

Merged
merged 11 commits into from
May 28, 2024

Conversation

toschneck
Copy link
Member

@toschneck toschneck commented Nov 9, 2023

closes https://github.com/kubermatic/sig-cs-infra/issues/62

What this PR does / why we need it:

Shows the ability how KKP and Terraform could interact. The Provider is considered as example to extend it to the custom needs and cloud providers. As first example kubevirt is added

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Adding KKP REST API Terraform provider (Scope: Example Implementation to extend to custom needs)
- Adding Examples How to manage KKP User Cluster with Cluster CRDs at the seed level

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 9, 2023
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 10, 2023
@toschneck toschneck changed the title WIP - KKP Terraform REST API Provider WIP - KKP User Cluster Management with Terrafrom Rest API and Cluster CRDs Nov 10, 2023
@dharapvj
Copy link
Contributor

dharapvj commented Nov 10, 2023

May we should add few more things via kubectl :

  1. Addon and AddonConfig CR
  2. ApplicationInstallation CR
  3. User-MLA Alerts (No CR I guess. Gets applied directly in Cortex?)
  4. User-MLA AlertManager config (AlertManager CR)

I can try to add these after your PR is merged

@toschneck toschneck self-assigned this Dec 18, 2023
@dharapvj
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@kubermatic-bot
Copy link

LGTM label has been added.

Git tree hash: 56cfc7228f21e54b529595d6d4f3cd4f4fe395ac

@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharapvj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
Co-authored-by: Vijay Dharap <vijay@kubermatic.com>
Signed-off-by: Tobias Schneck <tobias.schneck@kubermatic.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@toschneck
Copy link
Member Author

May we should add few more things via kubectl :

  1. Addon and AddonConfig CR
  2. ApplicationInstallation CR
  3. User-MLA Alerts (No CR I guess. Gets applied directly in Cortex?)
  4. User-MLA AlertManager config (AlertManager CR)

I can try to add these after your PR is merged

aggree created new issue for this #123

@toschneck toschneck changed the title WIP - KKP User Cluster Management with Terrafrom Rest API and Cluster CRDs KKP User Cluster Management with Terrafrom Rest API and Cluster CRDs May 28, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@toschneck
Copy link
Member Author

fixed issues and add architecture overview.

@toschneck
Copy link
Member Author

/lgtm

@kubermatic-bot
Copy link

@toschneck: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@toschneck toschneck merged commit 082c7c5 into master May 28, 2024
4 of 5 checks passed
@kubermatic-bot kubermatic-bot deleted the terraform-rest-provider branch May 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants