Change Connect button to open K8S Dashboard directly #1667
Conversation
kubermatic-bot
added
release-note
|
LGTM, one question. |
floreks
force-pushed
the
dashboard/proxy
branch
from
a6b69d7
to
c552e1f
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2139312a9827cc53d36183b9e781c3fffe0536f6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@floreks You can change the release notes too. |
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
- Coverage 71.66% 71.66% -0.01%
==========================================
Files 211 210 -1
Lines 6794 6783 -11
Branches 676 675 -1
==========================================
- Hits 4869 4861 -8
+ Misses 1663 1662 -1
+ Partials 262 260 -2
Continue to review full report at Codecov.
|
|
/test pull-dashboard-e2e-test |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Changed the
Connectbutton on details view to open Kubernetes Dashboard. Only owners and editors of the project will be able to use it and they will have admin access to the cluster in the Dashboard.One thing to improve in the API/UI would be to have some endpoint to validate status of Dashboard. If control plane is healthy, it does not mean that Dashboard pod is up and running. We could add some endpoint to check the status and only then enable the button.
Which issue(s) this PR fixes:
I am not sure if this already closes related issue or if we should still improve styling, etc.
Related to #1413
Release note: