Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about node deployment changes that will recreate all nodes #1479

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Aug 20, 2019

What this PR does / why we need it: Adds a warning if change made to the node deployment will trigger recreation of all nodes that belong to it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1382.

Special notes for your reviewer:

Zrzut ekranu 2019-08-20 o 08 02 28

Zrzut ekranu 2019-08-20 o 08 02 57

Zrzut ekranu 2019-08-20 o 08 02 41

Zrzut ekranu 2019-08-20 o 08 02 22

I will add unit tests.

Release note:

Added warning about node deployment changes that will recreate all nodes.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #1479 into master will decrease coverage by 0.12%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
- Coverage   72.49%   72.36%   -0.13%     
==========================================
  Files         207      208       +1     
  Lines        6525     6536      +11     
  Branches      633      637       +4     
==========================================
  Hits         4730     4730              
- Misses       1539     1549      +10     
- Partials      256      257       +1
Impacted Files Coverage Δ
src/app/shared/utils/common-utils.ts 100% <100%> (ø)
...tails/node-data-modal/node-data-modal.component.ts 76.19% <85.71%> (-7.15%) ⬇️
src/app/shared/entity/NodeEntity.ts 72.91% <0%> (-8.34%) ⬇️
...d-machine-network/add-machine-network.component.ts 67.5% <0%> (-5%) ⬇️
.../components/notification/notification.component.ts 80% <0%> (-4.45%) ⬇️
...cean-node-data/digitalocean-node-data.component.ts 75% <0%> (-1.39%) ⬇️
src/app/sshkey/sshkey.component.ts 88.23% <0%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2a12c...fb6578f. Read the comment docs.

@maciaszczykm maciaszczykm changed the title [WIP] Warn about node deployment changes that will recreate all nodes Warn about node deployment changes that will recreate all nodes Aug 20, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2019
@maciaszczykm
Copy link
Contributor Author

It's ready for a review.

@maciaszczykm
Copy link
Contributor Author

/test pre-build-dashboard-image

@kgroschoff
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a00bd9083b004f76f4f16a0dcbf58c896bcc7701

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@kubermatic-bot kubermatic-bot merged commit f16e0a5 into master Aug 20, 2019
@kubermatic-bot kubermatic-bot deleted the nd-warning branch August 20, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If possible, tell me if changing a node deployment will recreate all nodes.
3 participants