-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about node deployment changes that will recreate all nodes #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
- Coverage 72.49% 72.36% -0.13%
==========================================
Files 207 208 +1
Lines 6525 6536 +11
Branches 633 637 +4
==========================================
Hits 4730 4730
- Misses 1539 1549 +10
- Partials 256 257 +1
Continue to review full report at Codecov.
|
It's ready for a review. |
/test pre-build-dashboard-image |
/lgtm |
LGTM label has been added. Git tree hash: a00bd9083b004f76f4f16a0dcbf58c896bcc7701
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgroschoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Adds a warning if change made to the node deployment will trigger recreation of all nodes that belong to it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1382.Special notes for your reviewer:
I will add unit tests.
Release note: