-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KubeVirt #1608
Add support for KubeVirt #1608
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 71.92% 71.73% -0.19%
==========================================
Files 209 211 +2
Lines 6731 6792 +61
Branches 666 673 +7
==========================================
+ Hits 4841 4872 +31
- Misses 1632 1662 +30
Partials 258 258
Continue to review full report at Codecov.
|
Add animations for Angular Material with HammerJS import
@@ -68,6 +69,7 @@ const appearance: MatFormFieldDefaultOptions = { | |||
provide: MAT_FORM_FIELD_DEFAULT_OPTIONS, | |||
useValue: appearance, | |||
}, | |||
{provide: HAMMER_GESTURE_CONFIG, useClass: GestureConfig}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgroschoff @floreks Interesting thing: Sliders and some of Angular Material animations will only work with this in the code. Otherwise components show up, but you cannot smootly use slider for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@floreks We should use it in k8s/dashboard too.
Values that can be used for testing: https://github.com/kubermatic/kubermatic/pull/3942/files#diff-adda64b1de59f751a6e3a59b645067a1R83-R89 |
Kubeconfig is in our Vault. |
I already have a few "small" remarks from testing it locally:
Apart from those issues, everything seems to work fine (at least for me) And one general question that came to my mind: Will have a look into code now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me apart from the above mentioned comments, will let @floreks add the final lgtm 😄
hetzner: null, | ||
vsphere: null, | ||
azure: null, | ||
gcp: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@Input() cloudSpec: CloudSpec; | ||
@Input() nodeData: NodeData; | ||
@Input() clusterId: string; | ||
formGroup: FormGroup; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important at all, but: I think we're more or less using form
everywhere else. Maybe we want to stick to one pattern for all? I personally don't care if form
or formGroup
😅
/lgtm |
LGTM label has been added. Git tree hash: 88ad25aa82029258165215ecc17396ffcc7804f3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What this PR does / why we need it: Implements UI for API that got added in https://github.com/kubermatic/kubermatic/pull/3942/files#diff-adda64b1de59f751a6e3a59b645067a1R70.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1576.Special notes for your reviewer: Missing:
Release note: