Add support for KubeVirt #1608

maciaszczykm · 2019-09-25T11:51:00Z

What this PR does / why we need it: Implements UI for API that got added in https://github.com/kubermatic/kubermatic/pull/3942/files#diff-adda64b1de59f751a6e3a59b645067a1R70.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1576.

Special notes for your reviewer: Missing:

validation
which fields are required, what about defaulting
update wizard summary

Release note:

Added support for KubeVirt provider.

Add kubevirt structures

…pport

codecov · 2019-09-25T13:40:56Z

Codecov Report

Merging #1608 into master will decrease coverage by 0.18%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   71.92%   71.73%   -0.19%     
==========================================
  Files         209      211       +2     
  Lines        6731     6792      +61     
  Branches      666      673       +7     
==========================================
+ Hits         4841     4872      +31     
- Misses       1632     1662      +30     
  Partials      258      258

Impacted Files	Coverage Δ
src/app/testing/fake-data/cluster.fake.ts	`95.83% <ø> (ø)`	⬆️
src/app/testing/fake-data/node.fake.ts	`100% <ø> (ø)`	⬆️
src/app/shared/entity/NodeEntity.ts	`72.91% <ø> (ø)`	⬆️
...sting/fake-data/clusterWithMachineNetworks.fake.ts	`100% <ø> (ø)`	⬆️
src/app/testing/fake-data/cloud-spec.fake.ts	`100% <ø> (ø)`	⬆️
src/app/shared/entity/DatacenterEntity.ts	`88.88% <ø> (ø)`	⬆️
src/app/shared/entity/ClusterEntity.ts	`62.16% <0%> (-1.73%)`	⬇️
...rc/app/shared/utils/cluster-utils/cluster-utils.ts	`84.21% <0%> (-4.68%)`	⬇️
src/app/shared/model/NodeProviderConstants.ts	`100% <100%> (ø)`	⬆️
src/polyfills.ts	`100% <100%> (ø)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19b9ea...0079dd1. Read the comment docs.

Add animations for Angular Material with HammerJS import

maciaszczykm · 2019-09-26T10:40:40Z

src/app/app.module.ts

@@ -68,6 +69,7 @@ const appearance: MatFormFieldDefaultOptions = {
      provide: MAT_FORM_FIELD_DEFAULT_OPTIONS,
      useValue: appearance,
    },
+    {provide: HAMMER_GESTURE_CONFIG, useClass: GestureConfig},


@kgroschoff @floreks Interesting thing: Sliders and some of Angular Material animations will only work with this in the code. Otherwise components show up, but you cannot smootly use slider for example.

@floreks We should use it in k8s/dashboard too.

…pport

maciaszczykm · 2019-09-26T10:43:24Z

Values that can be used for testing: https://github.com/kubermatic/kubermatic/pull/3942/files#diff-adda64b1de59f751a6e3a59b645067a1R83-R89

maciaszczykm · 2019-09-26T10:43:40Z

Kubeconfig is in our Vault.

kgroschoff · 2019-09-26T10:59:42Z

I already have a few "small" remarks from testing it locally:

Could you remove the extended options bar, as there are no optional fields?
In Summary view, Provider headline could be removed if there is no preset and we don't want to display the kubeconfig.
Edit Provider Settings will cause error in browser dev console zone.js:3331 GET http://localhost:8000/api/v1/projects/jphvfsp68c/dc/europe-west3-c/clusters/52v8k7lwfn/health 404 (Not Found) - could you have a look, please? Edit Provider Settings is empty and I didn't get an error, but still, could you have a look please? 😅
Edit Cluster Name is not possible (we could probably fix this issue together with Renaming a cluster will throw errors #1583 )

Apart from those issues, everything seems to work fine (at least for me)

And one general question that came to my mind:
Should we stick with 1024M or 10Gi for input fields or do we want to enter e.g. Memory in GB (or whatever fits best)?

Will have a look into code now :)

kgroschoff

looks good to me apart from the above mentioned comments, will let @floreks add the final lgtm 😄

kgroschoff · 2019-09-26T11:06:44Z

src/app/testing/fake-data/cluster.fake.ts

-          hetzner: null,
-          vsphere: null,
-          azure: null,
-          gcp: null,


kgroschoff · 2019-09-26T11:07:00Z

src/app/node-data/kubevirt-add-node/kubevirt-node-data.component.ts

+  @Input() cloudSpec: CloudSpec;
+  @Input() nodeData: NodeData;
+  @Input() clusterId: string;
+  formGroup: FormGroup;


Not important at all, but: I think we're more or less using form everywhere else. Maybe we want to stick to one pattern for all? I personally don't care if form or formGroup 😅

floreks · 2019-09-27T09:27:27Z

/lgtm
/approve

kubermatic-bot · 2019-09-27T09:27:29Z

LGTM label has been added.

Git tree hash: 88ad25aa82029258165215ecc17396ffcc7804f3

kubermatic-bot · 2019-09-27T09:27:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

maciaszczykm · 2019-09-27T09:38:06Z

/retest

maciaszczykm · 2019-09-27T10:10:29Z

/retest

Marcin Maciaszczyk added 5 commits September 24, 2019 11:28

Cleanup mock structures

d184a1a

Add kubevirt structures

Update logo

9fdf894

Use KubeVirt name

0c967df

Merge remote-tracking branch 'origin/master' into feature/kubevirt-su…

77ba0c5

…pport

Implement KubeVirt wizard

0d18a55

Fix unit tests

295cdba

Marcin Maciaszczyk added 2 commits September 26, 2019 10:24

Add summary for KubeVirt

e12c053

Add node details for KubeVirt

6ecf055

kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2019

Add validation for KubeVirt node specs

4ee2f8e

Add animations for Angular Material with HammerJS import

kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2019

maciaszczykm commented Sep 26, 2019

View reviewed changes

maciaszczykm requested review from kgroschoff and floreks September 26, 2019 10:41

maciaszczykm changed the title ~~[WIP] Add support for KubeVirt~~ Add support for KubeVirt Sep 26, 2019

kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2019

Merge remote-tracking branch 'origin/master' into feature/kubevirt-su…

0079dd1

…pport

kubermatic-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2019

kgroschoff reviewed Sep 26, 2019

View reviewed changes

maciaszczykm assigned floreks Sep 27, 2019

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019

kubermatic-bot merged commit a48d322 into master Sep 27, 2019

kubermatic-bot deleted the feature/kubevirt-support branch September 27, 2019 10:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for KubeVirt #1608

Add support for KubeVirt #1608

maciaszczykm commented Sep 25, 2019 •

edited

Loading

codecov bot commented Sep 25, 2019 •

edited

Loading

maciaszczykm Sep 26, 2019

maciaszczykm Sep 26, 2019

maciaszczykm commented Sep 26, 2019

maciaszczykm commented Sep 26, 2019

kgroschoff commented Sep 26, 2019 •

edited

Loading

kgroschoff left a comment •

edited

Loading

kgroschoff Sep 26, 2019

kgroschoff Sep 26, 2019

floreks commented Sep 27, 2019

kubermatic-bot commented Sep 27, 2019

kubermatic-bot commented Sep 27, 2019

maciaszczykm commented Sep 27, 2019

maciaszczykm commented Sep 27, 2019

Add support for KubeVirt #1608

Add support for KubeVirt #1608

Conversation

maciaszczykm commented Sep 25, 2019 • edited Loading

codecov bot commented Sep 25, 2019 • edited Loading

Codecov Report

maciaszczykm Sep 26, 2019

Choose a reason for hiding this comment

maciaszczykm Sep 26, 2019

Choose a reason for hiding this comment

maciaszczykm commented Sep 26, 2019

maciaszczykm commented Sep 26, 2019

kgroschoff commented Sep 26, 2019 • edited Loading

kgroschoff left a comment • edited Loading

Choose a reason for hiding this comment

kgroschoff Sep 26, 2019

Choose a reason for hiding this comment

kgroschoff Sep 26, 2019

Choose a reason for hiding this comment

floreks commented Sep 27, 2019

kubermatic-bot commented Sep 27, 2019

kubermatic-bot commented Sep 27, 2019

maciaszczykm commented Sep 27, 2019

maciaszczykm commented Sep 27, 2019

maciaszczykm commented Sep 25, 2019 •

edited

Loading

codecov bot commented Sep 25, 2019 •

edited

Loading

kgroschoff commented Sep 26, 2019 •

edited

Loading

kgroschoff left a comment •

edited

Loading