Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod Node Selector Config #2929

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Pod Node Selector Config #2929

merged 4 commits into from
Jan 13, 2021

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it:
Added option to specify a Pod Node Selector Configuration during cluster creation or cluster edit. It will only be visible, when Pod Node Selector is enabled as Admission Plugin.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2884

Special notes for your reviewer:
podNodeSelectorConfig1
podNodeSelectorConfig2
podNodeSelectorConfig3

Release note:

Add option to specify Pod Node Selector Configuration

@kgroschoff kgroschoff self-assigned this Jan 12, 2021
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 12, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #2929 (0b7a3d1) into master (e683021) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
- Coverage   52.39%   52.33%   -0.07%     
==========================================
  Files         237      237              
  Lines        8201     8238      +37     
  Branches      985      999      +14     
==========================================
+ Hits         4297     4311      +14     
- Misses       3901     3924      +23     
  Partials        3        3
Impacted Files Coverage Δ
src/app/shared/entity/cluster.ts 56.86% <ø> (ø)
src/app/shared/services/cluster.service.ts 21.91% <0.00%> (-0.62%) ⬇️
...ared/components/label-form/label-form.component.ts 69.30% <83.33%> (+0.55%) ⬆️
.../cluster/cluster-details/edit-cluster/component.ts 86.11% <100.00%> (-0.85%) ⬇️
...count-token/edit-serviceaccount-token.component.ts 68.00% <0.00%> (-5.92%) ⬇️
src/app/member/add-member/add-member.component.ts 95.00% <0.00%> (-5.00%) ⬇️
...add-project-dialog/add-project-dialog.component.ts 95.23% <0.00%> (-4.77%) ⬇️
...add-serviceaccount/add-serviceaccount.component.ts 95.45% <0.00%> (-4.55%) ⬇️
...rc/app/member/edit-member/edit-member.component.ts 95.65% <0.00%> (-4.35%) ⬇️
...ettings/admin/admins/add-admin-dialog/component.ts 33.33% <0.00%> (-4.17%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e683021...0b7a3d1. Read the comment docs.

@kgroschoff
Copy link
Contributor Author

kgroschoff commented Jan 12, 2021 •
edited
Loading

@maciaszczykm / @floreks PTAL
also maybe @zreigz it would be good if you could have a brief look, if this is looking as expected

@zreigz
Copy link
Contributor

zreigz commented Jan 13, 2021

I will take a look, thanks

@zreigz
Copy link
Contributor

zreigz commented Jan 13, 2021

looks and works fine 👍

maciaszczykm
maciaszczykm reviewed Jan 13, 2021
View reviewed changes
src/app/shared/services/cluster.service.ts Outdated
@@ -93,6 +93,11 @@ export class ClusterService {
this._cluster.labels = labels;
}

set podNodeSelectorAdmissionPluginConfig(config: object) {
delete this._cluster.spec.podNodeSelectorAdmissionPluginConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line required? In the next one we are overwriting the same property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right. removed it.

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 65d778033a4d4f8c955f28934598e8ee897e2cc7

@kubermatic-bot kubermatic-bot merged commit 0315097 into kubermatic:master Jan 13, 2021
@kgroschoff kgroschoff deleted the feature/admission-plugin-config branch January 13, 2021 12:53
@kubermatic kubermatic deleted a comment from kubermatic-bot Jan 14, 2021
kgroschoff added a commit to kgroschoff/dashboard that referenced this pull request Jan 14, 2021
@kgroschoff
Pod Node Selector Config (kubermatic#2929)
1687cac 
* extend cluster spec by podNodeSelectorAdmissionPluginConfig

* add new field podNodeSelectorAdmissionPluginConfig to wizard creation & extend label-form

* add new field podNodeSelectorAdmissionPluginConfig to edit cluster dialog

* remove duplicate code
This was referenced Jan 14, 2021
Merged
Merged
kubermatic-bot pushed a commit that referenced this pull request Jan 18, 2021
@kgroschoff
Pod Node Selector Config (#2929) (#2957)
68cdcc9 
* extend cluster spec by podNodeSelectorAdmissionPluginConfig

* add new field podNodeSelectorAdmissionPluginConfig to wizard creation & extend label-form

* add new field podNodeSelectorAdmissionPluginConfig to edit cluster dialog

* remove duplicate code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm left review comments

Assignees

@maciaszczykm maciaszczykm

@kgroschoff kgroschoff

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add admission plugins configuration
4 participants
@kgroschoff @kubermatic-bot @zreigz @maciaszczykm