Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v2.15] Pod Node Selector Config #2957

Merged

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it:
Added option to specify a Pod Node Selector Configuration during cluster creation or cluster edit. It will only be visible, when Pod Node Selector is enabled as Admission Plugin.

cherry picked from #2929

Release note:

Add option to specify Pod Node Selector Configuration

* extend cluster spec by podNodeSelectorAdmissionPluginConfig

* add new field podNodeSelectorAdmissionPluginConfig to wizard creation & extend label-form

* add new field podNodeSelectorAdmissionPluginConfig to edit cluster dialog

* remove duplicate code
@kgroschoff kgroschoff self-assigned this Jan 14, 2021
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 14, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2021
@kgroschoff
Copy link
Contributor Author

/hold
should we wait for backend first?

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2957 (1687cac) into release/v2.15 (56b4468) will decrease coverage by 0.04%.
The diff coverage is 38.46%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v2.15    #2957      +/-   ##
=================================================
- Coverage          52.49%   52.44%   -0.05%     
=================================================
  Files                234      234              
  Lines               8188     8228      +40     
  Branches             999     1003       +4     
=================================================
+ Hits                4298     4315      +17     
- Misses              3887     3910      +23     
  Partials               3        3              
Impacted Files Coverage Δ
...pp/core/components/navigation/project/component.ts 36.17% <0.00%> (ø)
src/app/project/project.module.ts 100.00% <ø> (ø)
...mponents/external-cluster-data-dialog/component.ts 47.36% <0.00%> (ø)
src/app/shared/entity/addon.ts 60.00% <ø> (ø)
src/app/shared/entity/cluster.ts 63.55% <ø> (ø)
src/app/shared/entity/settings.ts 83.67% <ø> (ø)
src/app/shared/services/cluster.service.ts 21.62% <0.00%> (-1.57%) ⬇️
src/app/testing/services/settings-mock.service.ts 81.81% <ø> (ø)
src/app/wizard/step/cluster/ssh-keys/component.ts 72.58% <ø> (ø)
...error-notifications/error-notifications.service.ts 25.92% <6.66%> (-9.08%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f9752...1687cac. Read the comment docs.

@kgroschoff
Copy link
Contributor Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2021
@kgroschoff
Copy link
Contributor Author

@maciaszczykm / @floreks PTAL

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 47bd32955a15136b834c071b828f68700b49bc47

@kubermatic-bot kubermatic-bot merged commit 68cdcc9 into kubermatic:release/v2.15 Jan 18, 2021
@kgroschoff kgroschoff deleted the v15/podnodeselectorconfig branch January 18, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants