-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/v2.15] Pod Node Selector Config #2957
[release/v2.15] Pod Node Selector Config #2957
Conversation
* extend cluster spec by podNodeSelectorAdmissionPluginConfig * add new field podNodeSelectorAdmissionPluginConfig to wizard creation & extend label-form * add new field podNodeSelectorAdmissionPluginConfig to edit cluster dialog * remove duplicate code
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgroschoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Codecov Report
@@ Coverage Diff @@
## release/v2.15 #2957 +/- ##
=================================================
- Coverage 52.49% 52.44% -0.05%
=================================================
Files 234 234
Lines 8188 8228 +40
Branches 999 1003 +4
=================================================
+ Hits 4298 4315 +17
- Misses 3887 3910 +23
Partials 3 3
Continue to review full report at Codecov.
|
/hold cancel |
@maciaszczykm / @floreks PTAL |
/lgtm |
LGTM label has been added. Git tree hash: 47bd32955a15136b834c071b828f68700b49bc47
|
What this PR does / why we need it:
Added option to specify a Pod Node Selector Configuration during cluster creation or cluster edit. It will only be visible, when Pod Node Selector is enabled as Admission Plugin.
cherry picked from #2929
Release note: