Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Modules #2544

Merged
merged 4 commits into from Aug 6, 2020
Merged

Go Modules #2544

merged 4 commits into from Aug 6, 2020

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 6, 2020

What this PR does / why we need it:
Kubermatic switched to k8c.io/kubermatic/v2, this PR does the same for the dashboard. All leftovers from dep are removed as well.

Release note:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 6, 2020
@xrstf xrstf changed the title Go modules Go Modules Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020 •
edited

Codecov Report

Merging #2544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2544   +/-   ##
=======================================
  Coverage   51.31%   51.31%           
=======================================
  Files         226      226           
  Lines        7930     7930           
  Branches      926      926           
=======================================
  Hits         4069     4069           
  Misses       3859     3859           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054328e...314d7ac. Read the comment docs.

@xrstf
Copy link
Contributor Author

xrstf commented Aug 6, 2020

/retest

1 similar comment
@xrstf
Copy link
Contributor Author

xrstf commented Aug 6, 2020

/retest

@floreks
Copy link
Contributor

floreks commented Aug 6, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 788cb3fec267c15801c9fdca1a071f0006453d1d

@floreks
Copy link
Contributor

floreks commented Aug 6, 2020

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@kubermatic-bot kubermatic-bot merged commit d4e0973 into kubermatic:master Aug 6, 2020
@xrstf xrstf deleted the go-modules branch August 6, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @floreks @kubermatic-bot