Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide MLA section if it is not enabled on seed level #4488

Merged
merged 1 commit into from May 23, 2022

Conversation

Waseem826
Copy link
Contributor

Signed-off-by: Waseem Abbas waseemabbas8261@gmail.com

What this PR does / why we need it

Hide MLA section if it is not enabled on seed level for cluster details view.

Which issue(s) this PR fixes

Fixes #4482

Special notes for your reviewer

Release note

Hide MLA section if it is not enabled on seed level

Signed-off-by: Waseem Abbas <waseemabbas8261@gmail.com>
@Waseem826 Waseem826 self-assigned this May 18, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41c91a8f16eb867e0a1fee35b6f5ea882105128c

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #4488 (2dec7d5) into master (9e2e08a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #4488    +/-   ##
========================================
  Coverage   50.67%   50.67%            
========================================
  Files         340      340            
  Lines       12489    12489            
  Branches     1368     1654   +286     
========================================
  Hits         6329     6329            
+ Misses       6158     5819   -339     
- Partials        2      341   +339     
Impacted Files Coverage Δ
src/app/component.ts 76.38% <0.00%> (ø)
src/app/member/component.ts 58.77% <0.00%> (ø)
src/app/wizard/step/base.ts 22.22% <0.00%> (ø)
src/app/core/services/mla.ts 9.09% <0.00%> (ø)
src/app/core/services/opa.ts 6.73% <0.00%> (ø)
src/app/project/component.ts 59.36% <0.00%> (ø)
src/app/shared/utils/node.ts 4.16% <0.00%> (ø)
src/app/core/services/node.ts 36.92% <0.00%> (ø)
src/app/core/services/rbac.ts 12.50% <0.00%> (ø)
src/app/shared/entity/node.ts 45.65% <0.00%> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2e08a...2dec7d5. Read the comment docs.

@Waseem826
Copy link
Contributor Author

/retest

@maciaszczykm
Copy link
Contributor

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@kubermatic-bot kubermatic-bot merged commit 7beaaeb into master May 23, 2022
@kubermatic-bot kubermatic-bot deleted the 4482-hide-mla-section-if-disabled branch May 23, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide MLA section in "additional cluster information" if mla is disabled on seed level
4 participants