Add support for VMware Cloud Director provider

[Waseem826]

What does this PR do / Why do we need it:
This PR adds support for VMware Cloud Director as a cloud provider.

Create Preset

Cluster Wizard

Provider Settings

Node Settings

Which issue(s) this PR fixes :

Fixes #4536

Special notes for your reviewer:

Release Note:

Support for VMware Cloud Director as a cloud provider.

[kubermatic-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[Waseem826]

/test all

[codecov]

Codecov Report

Merging #4644 (e126253) into master (a120fc0) will decrease coverage by 0.16%.
The diff coverage is 35.82%.

@@            Coverage Diff             @@
##           master    #4644      +/-   ##
==========================================
- Coverage   50.39%   50.22%   -0.17%     
==========================================
  Files         346      359      +13     
  Lines       12897    13377     +480     
  Branches     1734     1823      +89     
==========================================
+ Hits         6499     6719     +220     
- Misses       6050     6284     +234     
- Partials      348      374      +26     

Impacted Files	Coverage Δ
...rvices/node-data/provider/vmware-cloud-director.ts	15.94% <15.94%> (ø)
.../services/wizard/provider/vmware-cloud-director.ts	16.39% <16.39%> (ø)
src/app/core/services/wizard/presets.ts	27.63% <33.33%> (+0.23%)	⬆️
...pp/core/services/provider/vmware-cloud-director.ts	40.00% <40.00%> (ø)
src/app/shared/entity/cluster.ts	78.23% <50.00%> (-1.63%)	⬇️
src/app/shared/entity/node.ts	44.23% <50.00%> (-0.22%)	⬇️
...ware-cloud-director-provider-settings/component.ts	88.46% <88.46%> (ø)
src/app/core/module.ts	98.57% <100.00%> (+0.04%)	⬆️
src/app/core/services/node-data/service.ts	77.31% <100.00%> (+0.97%)	⬆️
src/app/shared/entity/datacenter.ts	97.05% <100.00%> (+0.08%)	⬆️
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a120fc0...e126253. Read the comment docs.

[Waseem826]

/test all

[Waseem826]

/retest

[KhizerRehan]

PR comments

[Waseem826]

/hold
Waiting for backend changes and perhaps another review from @Talha-Jamil-TJ would be better since this is a large PR.

[kubermatic-bot]

@Waseem826: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pre-dashboard-test-full-e2e	e4055b6	link	false	/test pre-dashboard-test-full-e2e
pre-dashboard-test-full-e2e-ce	e4055b6	link	false	/test pre-dashboard-test-full-e2e-ce

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Talha-Jamil-TJ]

Changes requested

[ahmedwaleedmalik]

• Alignment issue
  

• The alignment here looks off. Since the logo for VCD is playing a part in here, can you please fix this in your PR?

[ahmedwaleedmalik]

To everyone involved with reviewing this PR. Sorry but the review on this PR was done not in the nicest of ways. Could have been better and more simpler ;)

1. If you have similar comments, instead of copy/pasting it to lots and lots of places. Just add a single comment and ask the person to update it everywhere.
2. If you are proposing some change, please share some context. Unless it's a very simple and obvious change.

I'm not sig-ui so refraining from a lot of technical comments. ¯_(ツ)_/¯

/meow

[kubermatic-bot]

@ahmedwaleedmalik:

In response to this:

To everyone involved with reviewing this PR. Sorry but the review on this PR was done quite poorly.

1. If you have similar comments, instead of copy/pasting it to 50 places. Just add a single comment and ask the person to update it everywhere.
2. If you are proposing some change, please share some context. Unless it's a very simple and obvious change.

I'm not sig-ui so refraining from a lot of technical comments ¯_(ツ)_/¯

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Waseem826]

/unhold

[KhizerRehan]

/approve
/lgtm

[kubermatic-bot]

LGTM label has been added.

Git tree hash: dc7b81c3a24505a642f44a36783a17a02b56479e

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KhizerRehan, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KhizerRehan,Waseem826]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment