New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete External Cluster MD #4657
Delete External Cluster MD #4657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4657 +/- ##
==========================================
- Coverage 50.39% 50.34% -0.05%
==========================================
Files 346 347 +1
Lines 12897 12928 +31
Branches 1734 1735 +1
==========================================
+ Hits 6499 6509 +10
+ Misses 6396 6070 -326
- Partials 2 349 +347
Continue to review full report at Codecov.
|
src/app/cluster/details/external-cluster/external-machine-deployment-details/template.html
Outdated
Show resolved
Hide resolved
src/app/cluster/details/external-cluster/external-machine-deployment-details/component.ts
Outdated
Show resolved
Hide resolved
src/app/cluster/details/external-cluster/external-machine-deployment-list/component.ts
Outdated
Show resolved
Hide resolved
src/app/cluster/details/external-cluster/external-machine-deployment-list/template.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback on PR comments
src/app/cluster/details/external-cluster/external-machine-deployment-details/template.html
Outdated
Show resolved
Hide resolved
84ffe44
to
521c4f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 3ca527f797bef4d511d5252d59f2b112c0433d0c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KhizerRehan, Waseem826 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do / Why do we need it:
This PR allows to Delete External Cluster machine deployment from External cluster details page and External Cluster Machine Deployment details page.
External cluster details page:
external-cluster-details-page.mp4
External Cluster Machine Deployment details page
external-cluster-details-md-details-page.mp4
Which issue(s) this PR fixes :
Fixes # #4629
Special notes for your reviewer:
Release Note: