Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete External Cluster MD #4657

Conversation

KhizerRehan
Copy link
Contributor

@KhizerRehan KhizerRehan commented Jul 6, 2022

What does this PR do / Why do we need it:

This PR allows to Delete External Cluster machine deployment from External cluster details page and External Cluster Machine Deployment details page.

External cluster details page:

external-cluster-details-page.mp4

External Cluster Machine Deployment details page

external-cluster-details-md-details-page.mp4

Which issue(s) this PR fixes :

Fixes # #4629

Special notes for your reviewer:

Release Note:

Add support for deleting machine deployments of External Cluster (EKS,AKS,GKE)

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2022
@KhizerRehan KhizerRehan removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #4657 (521c4f2) into master (904a2da) will decrease coverage by 0.04%.
The diff coverage is 32.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4657      +/-   ##
==========================================
- Coverage   50.39%   50.34%   -0.05%     
==========================================
  Files         346      347       +1     
  Lines       12897    12928      +31     
  Branches     1734     1735       +1     
==========================================
+ Hits         6499     6509      +10     
+ Misses       6396     6070     -326     
- Partials        2      349     +347     
Impacted Files Coverage Δ
...c/app/core/services/external-machine-deployment.ts 30.00% <30.00%> (ø)
src/app/core/module.ts 98.55% <100.00%> (+0.02%) ⬆️
src/app/component.ts 76.38% <0.00%> (ø)
src/app/member/component.ts 58.77% <0.00%> (ø)
src/app/wizard/step/base.ts 22.22% <0.00%> (ø)
src/app/core/services/mla.ts 9.09% <0.00%> (ø)
src/app/core/services/opa.ts 6.73% <0.00%> (ø)
src/app/project/component.ts 59.36% <0.00%> (ø)
src/app/shared/utils/node.ts 8.00% <0.00%> (ø)
src/app/core/services/node.ts 35.21% <0.00%> (ø)
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904a2da...521c4f2. Read the comment docs.

@KhizerRehan KhizerRehan changed the title Delete External Cluster MD EKS/AKS/GKE Delete External Cluster MD Jul 7, 2022
Copy link
Contributor Author

@KhizerRehan KhizerRehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback on PR comments

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@KhizerRehan KhizerRehan force-pushed the 4629-delete-external-cluster-machine-deployment branch from 84ffe44 to 521c4f2 Compare July 13, 2022 11:56
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ca527f797bef4d511d5252d59f2b112c0433d0c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KhizerRehan, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KhizerRehan,Waseem826]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 7ecfc19 into kubermatic:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants