Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to import Azure KubeOne cluster #5488

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Jan 2, 2023

What this PR does / why we need it:
Add support to import Azure KubeOne cluster.

Provider Step:

screenshot-localhost_8000-2023 01 02-14_46_20

Credentials Step:

screenshot-localhost_8000-2023 01 02-14_46_04

Summary Step:

screenshot-localhost_8000-2023 01 02-14_46_50

Which issue(s) this PR fixes:

Fixes #5471

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support to import Azure KubeOne cluster.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2023
@Waseem826
Copy link
Contributor Author

/test pre-dashboard-web-integration-tests-ce

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #5488 (70f7f2b) into main (73fbd6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5488   +/-   ##
=======================================
  Coverage   47.84%   47.84%           
=======================================
  Files         403      403           
  Lines       15887    15887           
  Branches     2485     2485           
=======================================
  Hits         7601     7601           
  Misses       8284     8284           
  Partials        2        2           
Impacted Files Coverage Δ
...dules/web/src/app/shared/entity/kubeone-cluster.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fbd6c...70f7f2b. Read the comment docs.

@Waseem826 Waseem826 force-pushed the 5471-add-support-to-import-azure-kubeone-cluster branch from a844323 to 70f7f2b Compare January 2, 2023 10:11
@KhizerRehan
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3217fee237f9c7ddbe955c77640b5a9b2d94ff02

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KhizerRehan, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Waseem826
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 415c57c into kubermatic:main Jan 2, 2023
@Waseem826 Waseem826 deleted the 5471-add-support-to-import-azure-kubeone-cluster branch January 2, 2023 13:55
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to import Azure KubeOne cluster
3 participants