Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to migrate KubeOne cluster container runtime #5499

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Jan 3, 2023

What this PR does / why we need it:
Add support to migrate KubeOne cluster container runtime from docker to containerd.

  • A new Migrate Container Runtime menu option has been added which is only enabled when cluster container runtime is docker.

screenshot-localhost_8000-2023 01 16-17_59_02

Migrate Container Runtime Dialog:

screenshot-localhost_8000-2023 01 16-17_59_18

Which issue(s) this PR fixes:

Fixes #5490

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 3, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@Waseem826 Waseem826 force-pushed the 5490-migrate-kubeone-cluster-container-runtime branch 5 times, most recently from d853544 to 9549c29 Compare January 16, 2023 09:17
@Waseem826 Waseem826 changed the title [WIP] Add support to migrate KubeOne cluster container runtime Add support to migrate KubeOne cluster container runtime Jan 16, 2023
@Waseem826 Waseem826 marked this pull request as ready for review January 16, 2023 09:31
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #5499 (734f8de) into main (e2d8a54) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5499   +/-   ##
=======================================
  Coverage   48.01%   48.01%           
=======================================
  Files         410      410           
  Lines       16275    16275           
  Branches     3054     3054           
=======================================
  Hits         7814     7814           
  Misses       8459     8459           
  Partials        2        2           
Impacted Files Coverage Δ
...ules/web/src/app/shared/entity/external-cluster.ts 43.28% <ø> (ø)
...dules/web/src/app/shared/entity/kubeone-cluster.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d8a54...734f8de. Read the comment docs.

@Waseem826 Waseem826 force-pushed the 5490-migrate-kubeone-cluster-container-runtime branch from 9549c29 to 734f8de Compare January 16, 2023 13:01
@ahmadhamzh ahmadhamzh requested review from ahmadhamzh and removed request for ahmadhamzh January 17, 2023 07:43
@ahmadhamzh
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bdb55ecfbedac396c2c4e53f89382ad26b846d6f

@kubermatic-bot kubermatic-bot merged commit d6f9601 into kubermatic:main Jan 17, 2023
@Waseem826 Waseem826 deleted the 5490-migrate-kubeone-cluster-container-runtime branch January 18, 2023 09:12
@kubermatic-bot kubermatic-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 15, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to migrate KubeOne cluster container runtime
3 participants