Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsiveness for smaller screen sizes #5801

Merged

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:

  • Collapse sidenav at 1500px screen width.
screencast-localhost_8000-2023.03.07-15_50_45.webm
  • Collapse Quota Widget at 1200px screen width.
screencast-localhost_8000-2023.03.07-15_48_16.webm
  • Adjust misc spacing issues.

Admin Settings Customization Page:

screenshot-localhost_8000-2023 03 07-16_00_38

External Clusters List Page:

screenshot-localhost_8000-2023 03 07-16_01_56

Which issue(s) this PR fixes:

Fixes #5732

What type of PR is this?

/kind design

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Improve page responsiveness  for smaller screen sizes.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/design Categorizes issue or PR as related to design. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2023
@Waseem826
Copy link
Contributor Author

cc @cschieder

@Waseem826 Waseem826 force-pushed the 5732-responsiveness-for-laptop-sizes branch from 9225920 to 431edde Compare March 7, 2023 11:14
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great job @Waseem826 👍

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f70761e2ef4ecfa51b4beb61385af097ffb4419f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 554aa53 into kubermatic:main Mar 7, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Mar 7, 2023
@Waseem826 Waseem826 deleted the 5732-responsiveness-for-laptop-sizes branch March 7, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Responsiveness for Laptop Sizes
3 participants