Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to import digitalocean kubeone cluster #5827

Merged
merged 1 commit into from
May 3, 2023
Merged

Add support to import digitalocean kubeone cluster #5827

merged 1 commit into from
May 3, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Mar 13, 2023 •
edited by ahmedwaleedmalik

What this PR does / why we need it:
Add support to import digitalocean KubeOne cluster.

Provider Step:
image

Credentials Step:
image

Summary Step:
image

Which issue(s) this PR fixes:
Fixes #5820

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support to import digitalocean KubeOne cluster

NONE

@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2023
@ahmadhamzh ahmadhamzh changed the title add support to import digitalocean kubeone cluster WIP add support to import digitalocean kubeone cluster Mar 13, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5820-add-digital-ocean-kubeone branch from 25c02f1 to 79ff99e Compare March 13, 2023 20:06
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Mar 13, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5820-add-digital-ocean-kubeone branch 2 times, most recently from 5644b8f to bb61267 Compare March 14, 2023 09:03
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request May 2, 2023
Merged
@ahmadhamzh ahmadhamzh force-pushed the 5820-add-digital-ocean-kubeone branch from bb61267 to 01970e8 Compare May 3, 2023 11:39
@ahmadhamzh ahmadhamzh changed the title WIP add support to import digitalocean kubeone cluster Add support to import digitalocean kubeone cluster May 3, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c300c3221e1ddfeec42cc3d68a7c6361e2ac2aab

@ahmedwaleedmalik
Copy link
Member

/approve cancel

@ahmadhamzh ahmadhamzh force-pushed the 5820-add-digital-ocean-kubeone branch from 01970e8 to 0f9e716 Compare May 3, 2023 12:03
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc960cd67975668564b71b52cc954a34383e13bd

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 06b22de into kubermatic:main May 3, 2023
10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Add credential page for KubeOne DigitalOcean
3 participants
@ahmadhamzh @kubermatic-bot @ahmedwaleedmalik